On Monday, September 19, 2016 11:21:50 AM CEST Mark Brown wrote: > On Wed, Sep 14, 2016 at 06:11:37PM +0100, Mark Brown wrote: > > On Wed, Sep 14, 2016 at 09:18:08AM +0100, Build bot for Mark Brown wrote: > > > Today's -next fails to build both arm and arm64 allmodconfig due to: > > > > arm64-allmodconfig > > > ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined! > > > > arm-allmodconfig > > > ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined! > > > due to 262d5cc6ceb293 (mfd: tps65217: Add support for IRQs) since > > irq_set_parent() isn't exported. > > This is still breaking the build, do we have any ETA on getting the > export added? Thomas said he'd add it if the export is needed, but so far nobody could tell if it is, or if the correct fix is something else, so I have not sent a patch for inclusion. My guess is that this is indeed the correct fix, but I don't understand at all what the function does, and Marcin Niestroj said the same thing, he just copied the code from a driver that is always built-in. FWIW, the original function is static int regmap_irq_map(struct irq_domain *h, unsigned int virq, irq_hw_number_t hw) { struct regmap_irq_chip_data *data = h->host_data; irq_set_chip_data(virq, data); irq_set_chip(virq, &data->irq_chip); irq_set_nested_thread(virq, 1); irq_set_parent(virq, data->irq); irq_set_noprobe(virq); return 0; } and this is the new one: static int tps65217_irq_map(struct irq_domain *h, unsigned int virq, irq_hw_number_t hw) { struct tps65217 *tps = h->host_data; irq_set_chip_data(virq, tps); irq_set_chip_and_handler(virq, &tps65217_irq_chip, handle_edge_irq); irq_set_nested_thread(virq, 1); irq_set_parent(virq, tps->irq); irq_set_noprobe(virq); return 0; } twl6030_irq_map() has another almost identical copy, and the only other caller of irq_set_parent() is gpiochip_set_chained_irqchip(), which is completely different. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html