On Sun, 24 Jul 2016, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > In file included from include/linux/clocksource.h:18:0, > from include/linux/clockchips.h:13, > from drivers/clocksource/jcore-pit.c:14: > include/linux/of.h:1004:20: warning: comparison of distinct pointer types lacks a cast > .data = (fn == (fn_type)NULL) ? fn : fn } > ^ > include/linux/of.h:1020:3: note: in expansion of macro '_OF_DECLARE' > _OF_DECLARE(table, name, compat, fn, of_init_fn_1_ret) > ^ > include/linux/clocksource.h:247:2: note: in expansion of macro 'OF_DECLARE_1_RET' > OF_DECLARE_1_RET(clksrc, name, compat, fn) > ^ > drivers/clocksource/jcore-pit.c:277:1: note: in expansion of macro 'CLOCKSOURCE_OF_DECLARE' > CLOCKSOURCE_OF_DECLARE(jcore_pit, "jcore,pit", jcore_pit_init); > ^ > > Introduced by commits > > b7c4db861683 ("clocksource/drivers/clksrc-probe: Introduce init functions with return code") > 177cf6e52b0a ("clocksources: Switch back to the clksrc table") > > interacting with commit > > e0aa0655c60b ("clocksource: add J-Core timer/clocksource driver") > > from the sh tree. And why is that driver coming through the superh tree and not through the clocksource maintainers? It's not only based on an old interface it's probably unreviewed as well ... Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html