On Fri 2016-06-03 17:12:44, William Breathitt Gray wrote: > On Fri, Jun 03, 2016 at 10:57:03PM +0200, Pavel Machek wrote: > >Hi! > > > >> With the introduction of the ISA_BUS_API Kconfig option, ISA-style > >> drivers may be built for X86_64 architectures. This patch changes the > >> ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus > >> allowing them to build for X86_64 as they are expected to. > >> > >> Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > >> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > >> Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx> > >> --- > >> drivers/gpio/Kconfig | 8 ++++---- > >> 1 file changed, 4 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > >> index 48da857..dc6da77 100644 > >> --- a/drivers/gpio/Kconfig > >> +++ b/drivers/gpio/Kconfig > >> @@ -530,7 +530,7 @@ menu "Port-mapped I/O GPIO drivers" > >> > >> config GPIO_104_DIO_48E > >> tristate "ACCES 104-DIO-48E GPIO support" > >> - depends on ISA > >> + depends on ISA_BUS_API > >> select GPIOLIB_IRQCHIP > >> help > >> Enables GPIO support for the ACCES 104-DIO-48E series > > > >Should we do "depends on PC104" here, because that is what it really > >means, and have PC104 enabled when ISA_BUS_API is enabled or something > >like that? > > Since the functionality remains the same, I'm a bit indifferent to that > change; as long as the driver builds for systems in which it's intended > to be used, I'm satisfied. > > Differentiating between PC/104 and ISA may be a pointless endeavor > though since both buses appear the same to software. But if it is better > to differentiate between devices as such, then I see little harm in > adding a PC104 Kconfig option which follows the ISA_BUS_API Kconfig > option. Well, they are same to the software, but not at the hardware. If I have a development board that has PC104 (but not isa), I'd like to see prompts for PC104 extensions, not for isa. If PC105 comes out, still ISA compatible, I will want to see prompts for PC104 boards or PC105 boards, but not neccessarily both... Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
