Hi Al, After merging the vfs tree, today's linux-next build (arm multi_v7_defconfig) failed like this: In file included from drivers/usb/core/devio.c:37:0: drivers/usb/core/devio.c: In function 'usbdev_lseek': include/linux/fs.h:898:36: error: 'PAGE_CACHE_SIZE' undeclared (first use in this function) #define MAX_LFS_FILESIZE (((loff_t)PAGE_CACHE_SIZE << (BITS_PER_LONG-1))-1) ^ drivers/usb/core/devio.c:162:48: note: in expansion of macro 'MAX_LFS_FILESIZE' return no_seek_end_llseek(file, offset, orig, MAX_LFS_FILESIZE); ^ include/linux/fs.h:898:36: note: each undeclared identifier is reported only once for each function it appears in #define MAX_LFS_FILESIZE (((loff_t)PAGE_CACHE_SIZE << (BITS_PER_LONG-1))-1) ^ drivers/usb/core/devio.c:162:48: note: in expansion of macro 'MAX_LFS_FILESIZE' return no_seek_end_llseek(file, offset, orig, MAX_LFS_FILESIZE); ^ drivers/usb/core/devio.c:163:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ Caused by commit 41fb31e4f962 ("new helper: no_seek_end_llseek()") PAGE_CACHE_SIZE is defined in linux/pagemap.h which is not included here. I guess that adding the include to linux/fs.h may have other problems. I have used the vfs tree from next-20151207 for today. -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html