Hi Stephen,
On 2015년 08월 17일 14:53, Stephen Rothwell wrote:
> Hi Inki,
>
> On Mon, 17 Aug 2015 13:53:42 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>>
>> On Mon, 17 Aug 2015 13:51:30 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>>>
>>> After merging the drm-exynos tree, today's linux-next build (arm
>>> multi_v7_defconfig) failed like this:
>>>
>>> drivers/gpu/drm/exynos/exynos_mixer.c: In function 'vp_video_buffer':
>>> drivers/gpu/drm/exynos/exynos_mixer.c:395:15: error: 'struct exynos_drm_plane' has no member named 'pixel_format'
>>> switch (plane->pixel_format) {
>>> ^
>>> In file included from drivers/gpu/drm/exynos/exynos_mixer.c:17:0:
>>> drivers/gpu/drm/exynos/exynos_mixer.c:404:10: error: 'struct exynos_drm_plane' has no member named 'pixel_format'
>>> plane->pixel_format);
>>> ^
>>> include/drm/drmP.h:164:17: note: in definition of macro 'DRM_ERROR'
>>> drm_err(fmt, ##__VA_ARGS__)
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:411:11: error: 'struct exynos_drm_plane' has no member named 'scan_flag'
>>> if (plane->scan_flag & DRM_MODE_FLAG_INTERLACE) {
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:417:39: error: 'struct exynos_drm_plane' has no member named 'pitch'
>>> luma_addr[1] = luma_addr[0] + plane->pitch;
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:418:43: error: 'struct exynos_drm_plane' has no member named 'pitch'
>>> chroma_addr[1] = chroma_addr[0] + plane->pitch;
>>> ^
>>> In file included from drivers/gpu/drm/exynos/exynos_mixer.c:20:0:
>>> drivers/gpu/drm/exynos/exynos_mixer.c:439:53: error: 'struct exynos_drm_plane' has no member named 'pitch'
>>> vp_reg_write(res, VP_IMG_SIZE_Y, VP_IMG_HSIZE(plane->pitch) |
>>> ^
>>> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>>> (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:439:35: note: in expansion of macro 'VP_IMG_HSIZE'
>>> vp_reg_write(res, VP_IMG_SIZE_Y, VP_IMG_HSIZE(plane->pitch) |
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:440:21: error: 'struct exynos_drm_plane' has no member named 'fb_height'
>>> VP_IMG_VSIZE(plane->fb_height));
>>> ^
>>> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>>> (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:440:3: note: in expansion of macro 'VP_IMG_VSIZE'
>>> VP_IMG_VSIZE(plane->fb_height));
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:442:53: error: 'struct exynos_drm_plane' has no member named 'pitch'
>>> vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(plane->pitch) |
>>> ^
>>> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>>> (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:442:35: note: in expansion of macro 'VP_IMG_HSIZE'
>>> vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(plane->pitch) |
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:443:21: error: 'struct exynos_drm_plane' has no member named 'fb_height'
>>> VP_IMG_VSIZE(plane->fb_height / 2));
>>> ^
>>> drivers/gpu/drm/exynos/regs-vp.h:59:5: note: in definition of macro 'VP_MASK_VAL'
>>> (((val) << (low_bit)) & VP_MASK(high_bit, low_bit))
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:443:3: note: in expansion of macro 'VP_IMG_VSIZE'
>>> VP_IMG_VSIZE(plane->fb_height / 2));
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:445:39: error: 'struct exynos_drm_plane' has no member named 'src_width'
>>> vp_reg_write(res, VP_SRC_WIDTH, plane->src_width);
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:446:40: error: 'struct exynos_drm_plane' has no member named 'src_height'
>>> vp_reg_write(res, VP_SRC_HEIGHT, plane->src_height);
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:451:39: error: 'struct exynos_drm_plane' has no member named 'crtc_width'
>>> vp_reg_write(res, VP_DST_WIDTH, plane->crtc_width);
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:454:41: error: 'struct exynos_drm_plane' has no member named 'crtc_height'
>>> vp_reg_write(res, VP_DST_HEIGHT, plane->crtc_height / 2);
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:457:41: error: 'struct exynos_drm_plane' has no member named 'crtc_height'
>>> vp_reg_write(res, VP_DST_HEIGHT, plane->crtc_height);
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:472:27: error: 'struct exynos_drm_plane' has no member named 'mode_height'
>>> mixer_cfg_scan(ctx, plane->mode_height);
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c:473:30: error: 'struct exynos_drm_plane' has no member named 'mode_height'
>>> mixer_cfg_rgb_fmt(ctx, plane->mode_height);
>>> ^
>>> drivers/gpu/drm/exynos/exynos_mixer.c: In function 'mixer_setup_scale':
>>> drivers/gpu/drm/exynos/exynos_mixer.c:494:11: error: 'const struct exynos_drm_plane' has no member named 'crtc_width
>>
>> Hmm, my message was truncated ...
>>
>> I assume that there was a conflicting change in some other tree, and so
>> have dropped this tree for today (hopefully it will be fixed up soon or
>> you can tell me how to fix this).
>
> Actually it looks like this was caused by commit
>
> a97f353797b4 ("drm/exynos: remove unused fields from struct exynos_drm_plane")
>
> but only exposed today (maybe by some Kconfig dependency changing so
> that drivers/gpu/drm/exynos/exynos_mixer.c is now built).
I tried to build it with multi_v7_defconfig but I couldn't see any build
error.
Below is commit of linux-next tree I tested,
commit b00278812ebaae29769666ef556abc20a4680581
Merge: ad1d24c c098dc8
Author: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Date: Fri Aug 14 12:06:53 2015 +1000
Merge remote-tracking branch 'drm-exynos/exynos-drm/for-next
And today, I re-based exynos-drm/for-next on top of mainline. Could you
update and try to build it again?
Thanks,
Inki Dae
>
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
