Re: ASoC: cs4349: Add support for Cirrus Logic CS4349 breaks on multiple arch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

On Sat, Jul 18, 2015 at 4:28 PM, Paul Gortmaker
<paul.gortmaker@xxxxxxxxxxxxx> wrote:
> Hi Tim,
>
> This commit:
>
> e40da86a37f64c73b810bc7a63d77c44dc61accb is the first bad commit
> commit e40da86a37f64c73b810bc7a63d77c44dc61accb
> Author: Tim Howe <tim.howe@xxxxxxxxxx>
> Date:   Thu Jul 16 14:51:40 2015 -0500
>
>     ASoC: cs4349: Add support for Cirrus Logic CS4349
>
>     Signed-off-by: Tim Howe <tim.howe@xxxxxxxxxx>
>     Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
>
> is showing up in linux-next build failures for mips, parisc and s390.
>
> sound/soc/codecs/cs4349.c:300:2: error: implicit declaration of function
> 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration]
> sound/soc/codecs/cs4349.c:301:12: error: 'GPIOD_OUT_LOW' undeclared
> (first use in this function)
> sound/soc/codecs/cs4349.c:306:3: error: implicit declaration of function
> 'gpiod_set_value_cansleep' [-Werror=implicit-function-declaration]
>
> Here are a few examples:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12465322/
> http://kisskb.ellerman.id.au/kisskb/buildresult/12465445/
> http://kisskb.ellerman.id.au/kisskb/buildresult/12465246/
>
> I'm guessing it needs some tighter Kconfig dependencies to block it
> from being selected on arch that don't have/enable gpio stuff.

Would this fix the problem?

+++ b/sound/soc/codecs/Kconfig
@@ -53,7 +53,7 @@ config SND_SOC_ALL_CODECS
        select SND_SOC_CS4271_I2C if I2C
        select SND_SOC_CS4271_SPI if SPI_MASTER
        select SND_SOC_CS42XX8_I2C if I2C
-       select SND_SOC_CS4349 if I2C
+       select SND_SOC_CS4349 if I2C && GPIOLIB
        select SND_SOC_CX20442 if TTY
        select SND_SOC_DA7210 if SND_SOC_I2C_AND_SPI
        select SND_SOC_DA7213 if I2C
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux