On Fri, Jun 26, 2015 at 7:13 AM, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> wrote: > On Thu, Jun 25, 2015 at 11:24 AM, Paul Gortmaker > <paul.gortmaker@xxxxxxxxxxxxx> wrote: >> >> New breakage seen in linux-next today: >> >> ERROR: "__xchg_called_with_bad_pointer" [fs/nfs/flexfilelayout/nfs_layout_flexfiles.ko] undefined! >> ERROR: "__cmpxchg_called_with_bad_pointer" [fs/nfs/flexfilelayout/nfs_layout_flexfiles.ko] undefined! >> make[2]: *** [__modpost] Error 1 >> make[1]: *** [modules] Error 2 >> >> I tried to reproduce it locally so I could run a bisect, >> but it must be toolchain specific because I don't see it. >> > > Sigh. It looks as if xchg() and cmpxchg() are not available for 64-bit > integers on sparc32. > Tao, can we rely on mirror->lock to provide atomicity here instead? > yes, we can. It is already under mirror->lock. So we just need to open code xchg/cmpxchg(). I'll send a patch to fix it. Cheers, Tao -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
