Hi Thierry, This commit: commit 436b6428b9cc97f61721f335eb9d8010751a337e Author: Thierry Reding <treding@xxxxxxxxxx> Date: Wed Apr 29 16:54:04 2015 +0200 soc/tegra: fuse: Unify Tegra20 and Tegra30 drivers in linux-next, in combination with my pending init cleanup http://marc.info/?l=linux-kernel&m=143327626201054&w=2 will cause a compile fail because 43b642 is relying on an implicit include of <linux/module.h> to provide the fcn for: +module_platform_driver(tegra_fuse_driver); which in turn causes: drivers/soc/tegra/fuse/fuse-tegra.c:171:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int] drivers/soc/tegra/fuse/fuse-tegra.c:171:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int] Can you add the include to your tree please? I think it makes more sense to be there vs. me preemptively adding it to mine. BTW, I think we can look at converting your driver to use the alternate fcn builtin_platform_driver later, once that branch is merged. https://lwn.net/Articles/643854/ Thanks, Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html