next-20150511 / omap2-mcspi: regression for sdp4430 boot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

SDP4430 uses a SPI based network chip ks8851.

next-20150508:
https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt

However, next-20150511:
https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt

Generates infinite "ks8851 spi1.0: ks8851_irq: spi bus error" errors
and hangs the platform.

Bisected the issue down to the following two commits when reverted
allows the board to function:


commit b28cb9414db9f8e42ac18c9e360e4e99cda42489
Author: Michael Welling <mwelling@xxxxxxxx>
Date:   Thu May 7 18:36:53 2015 -0500

    spi: omap2-mcspi: Switch driver to use transfer_one

    Switches from transfer_one_message to transfer_one to prepare
driver for
    use of GPIO chip selects.

    Signed-off-by: Michael Welling <mwelling@xxxxxxxx>
    Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

Reverting this alone: http://paste.ubuntu.org.cn/2594735 (did not boot up)

commit bc7f9bbc80bcc77745b3f54ec4e7103e3e142bb9
Author: Michael Welling <mwelling@xxxxxxxx>
Date:   Fri May 8 13:31:01 2015 -0500

    spi: omap2-mcspi: Add gpio_request and init CS

    If GPIO chip select is specified, request the GPIO in the setup
function
    and release it in the cleanup function.

    Signed-off-by: Michael Welling <mwelling@xxxxxxxx>
    Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

Reverting this as well allowed boot.

-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux