On Tue, Apr 14, 2015 at 05:02:15PM -0400, Theodore Ts'o wrote: > On Tue, Apr 14, 2015 at 06:17:43PM +0100, Al Viro wrote: > > Except that you do not handle the slow unencrypted case - you end up with > > kfree() on the freshly kunmaped address. > > Ah, right, we're actually kmalloc'ing the space that case as well --- > so hanging on the cpage is pointless; which was the point you were > making. Sorry, I was being slow. > > So what we have works, but it's not optimal. Will fix. BTW, take a look at kfree_put_link(); no need to reinvent that wheel... -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html