> On 05.12.2014 05:24, David Miller wrote: > Do not use select, please. > > You can only use select on leaf node Kconfig symbols, ie. those > which do not have any dependencies whatsoever. > > Select does not recursively walk down the dependency chain turning > things on for you when you say "select X". > Okay, sure, my bad for not looking that up properly. If we change this into a "depends on", this should not be a problem, right? If CONFIG_BRIDGE is selected as 'm', then CONFIG_ROCKER can only be 'n' or 'm', if CONFIG_BRIDGE is set to 'y', it can be 'n', 'm' or 'y'. This also means that the prompt associated with CONFIG_ROCKER will only show up in menuconfig when CONFIG_BRIDGE has been enabled (either 'm' or 'y'). I've attached an updated patch.
From 931a36cc5ec67ec23ba2373d42840d968ed78120 Mon Sep 17 00:00:00 2001 From: Andreas Ruprecht <rupran@xxxxxxxxxxxx> Date: Thu, 4 Dec 2014 18:28:09 +0100 Subject: [PATCH] net: ethernet: rocker: Add dependency to CONFIG_BRIDGE in Kconfig In a configuration with CONFIG_BRIDGE set to 'm' and CONFIG_ROCKER set to 'y', undefined references occur at link time: > drivers/built-in.o: In function `rocker_port_fdb_learn_work': > /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3014: undefined > reference to `br_fdb_external_learn_del' > /home/jim/linux/drivers/net/ethernet/rocker/rocker.c:3016: undefined > reference to `br_fdb_external_learn_add' This patch fixes these by declaring CONFIG_ROCKER as being dependent on CONFIG_BRIDGE. Reported-by: Jim Davis <jim.epost@xxxxxxxxx> Signed-off-by: Andreas Ruprecht <rupran@xxxxxxxxxxxx> --- drivers/net/ethernet/rocker/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/rocker/Kconfig b/drivers/net/ethernet/rocker/Kconfig index 11a850eab628..b9952ef040e4 100644 --- a/drivers/net/ethernet/rocker/Kconfig +++ b/drivers/net/ethernet/rocker/Kconfig @@ -17,7 +17,7 @@ if NET_VENDOR_ROCKER config ROCKER tristate "Rocker switch driver (EXPERIMENTAL)" - depends on PCI && NET_SWITCHDEV + depends on PCI && NET_SWITCHDEV && BRIDGE ---help--- This driver supports Rocker switch device. -- 1.9.1
