Hi Wolfram, After merging the i2c tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/i2c/busses/i2c-rk3x.c: In function 'rk3x_i2c_clk_notifier_cb': drivers/i2c/busses/i2c-rk3x.c:634:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function) case PRE_RATE_CHANGE: ^ drivers/i2c/busses/i2c-rk3x.c:634:7: note: each undeclared identifier is reported only once for each function it appears in drivers/i2c/busses/i2c-rk3x.c:635:31: error: dereferencing pointer to incomplete type if (rk3x_i2c_calc_divs(ndata->new_rate, i2c->scl_frequency, ^ drivers/i2c/busses/i2c-rk3x.c:641:12: error: dereferencing pointer to incomplete type if (ndata->new_rate > ndata->old_rate) ^ drivers/i2c/busses/i2c-rk3x.c:641:30: error: dereferencing pointer to incomplete type if (ndata->new_rate > ndata->old_rate) ^ drivers/i2c/busses/i2c-rk3x.c:642:33: error: dereferencing pointer to incomplete type rk3x_i2c_adapt_div(i2c, ndata->new_rate); ^ drivers/i2c/busses/i2c-rk3x.c:645:7: error: 'POST_RATE_CHANGE' undeclared (first use in this function) case POST_RATE_CHANGE: ^ drivers/i2c/busses/i2c-rk3x.c:647:12: error: dereferencing pointer to incomplete type if (ndata->new_rate < ndata->old_rate) ^ drivers/i2c/busses/i2c-rk3x.c:647:30: error: dereferencing pointer to incomplete type if (ndata->new_rate < ndata->old_rate) ^ drivers/i2c/busses/i2c-rk3x.c:648:33: error: dereferencing pointer to incomplete type rk3x_i2c_adapt_div(i2c, ndata->new_rate); ^ drivers/i2c/busses/i2c-rk3x.c:650:7: error: 'ABORT_RATE_CHANGE' undeclared (first use in this function) case ABORT_RATE_CHANGE: ^ drivers/i2c/busses/i2c-rk3x.c:652:12: error: dereferencing pointer to incomplete type if (ndata->new_rate > ndata->old_rate) ^ drivers/i2c/busses/i2c-rk3x.c:652:30: error: dereferencing pointer to incomplete type if (ndata->new_rate > ndata->old_rate) ^ drivers/i2c/busses/i2c-rk3x.c:653:33: error: dereferencing pointer to incomplete type rk3x_i2c_adapt_div(i2c, ndata->old_rate); ^ drivers/i2c/busses/i2c-rk3x.c: In function 'rk3x_i2c_probe': drivers/i2c/busses/i2c-rk3x.c:941:2: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration] ret = clk_notifier_register(i2c->clk, &i2c->clk_rate_nb); ^ drivers/i2c/busses/i2c-rk3x.c:961:2: error: implicit declaration of function 'clk_notifier_unregister' [-Werror=implicit-function-declaration] clk_notifier_unregister(i2c->clk, &i2c->clk_rate_nb); ^ Caused by commit 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes correctly"). I have reverted that commit for today. -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
Attachment:
pgp40EbcKMP4v.pgp
Description: OpenPGP digital signature