On 09/19/14 15:28, Anish Bhatt wrote:
> Is it completely acceptable to have default configs that select menu entries
> but not their dependencies ? Since essentially earlier the select on
> SCSI_NETLINK select used to select NET but no longer does, so I'm wondering
> if this was an oversight earlier. Is this something that's supposed to be
> automatically resolved ?
> -Anish
Mostly be aware of what Documentation/kbuild/kconfig-language.txt says:
Note:
select should be used with care. select will force
a symbol to a value without visiting the dependencies.
By abusing select you are able to select a symbol FOO even
if FOO depends on BAR that is not set.
In general use select only for non-visible symbols
(no prompts anywhere) and for symbols with no dependencies.
That will limit the usefulness but on the other hand avoid
the illegal configurations all over.
> ________________________________________
> From: Randy Dunlap [rdunlap@xxxxxxxxxxxxx]
> Sent: Friday, September 19, 2014 3:21 PM
> To: Guenter Roeck; Stephen Rothwell
> Cc: linux-next@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Anish Bhatt; David S. Miller; James E.J. Bottomley
> Subject: Re: linux-next: Tree for Sep 19
>
> On 09/19/14 14:14, Guenter Roeck wrote:
>> On Fri, Sep 19, 2014 at 04:58:17PM +1000, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20140917:
>>>
>>> The fsl tree still had its build failure so I used the version from
>>> next-20140917.
>>>
>>> The v4l-dvb tree lost its build failure.
>>>
>>> The security tree gained a conflict against the file-locks tree.
>>>
>>> Non-merge commits (relative to Linus' tree): 6014
>>> 5488 files changed, 217522 insertions(+), 129375 deletions(-)
>>>
>>> ----------------------------------------------------------------------------
>>>
>> Guess this is most difficult one.
>>
>> mips:nlm_xlp_defconfig:
>>
>> warning: (SCSI_BNX2X_FCOE && LIBFCOE && TCM_QLA2XXX) selects LIBFC which has
>> unmet direct dependencies (SCSI_LOWLEVEL && SCSI && SCSI_FC_ATTRS)
>> warning: (SCSI_BNX2X_FCOE && LIBFCOE && TCM_QLA2XXX) selects LIBFC which has
>> unmet direct dependencies (SCSI_LOWLEVEL && SCSI && SCSI_FC_ATTRS)
>
> Yes, I have a patch sitting on my hard drive that makes LIBFCOE and TCM_QLA2XXX
> and SCSI_BNX2X_FCOE depend on SCSI_FC_ATTRS, but I'm not entirely happy about
> having to hunt these down (even with the help of kconfig warnings).
>
> I'm pretty sure that I can fix these (above and build errors below), but
> there is still a bunch of nasty kconfig warnings that I don't understand
> and don't know how to fix:
>
> (powerpc ppc64_defconfig) produced these warnings:
>
> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM)
>
>
> git bisect also points to the SCSI_NETLINK dependency commit for these (unless
> I did the bisect incorrectly).
>
> Does anyone have a clue on these?
> Thanks.
>
>
>> followed by:
>>
>> ERROR: "scsi_is_fc_rport" [drivers/scsi/libfc/libfc.ko] undefined!
>> ERROR: "fc_get_event_number" [drivers/scsi/libfc/libfc.ko] undefined!
>> ERROR: "skb_trim" [drivers/scsi/libfc/libfc.ko] undefined!
>> ERROR: "fc_host_post_event" [drivers/scsi/libfc/libfc.ko] undefined!
>> ERROR: "__alloc_skb" [drivers/scsi/libfc/libfc.ko] undefined!
>> ERROR: "fc_remote_port_delete" [drivers/scsi/libfc/libfc.ko] undefined!
>> ERROR: "kfree_skb" [drivers/scsi/libfc/libfc.ko] undefined!
>> ERROR: "fc_block_scsi_eh" [drivers/scsi/libfc/libfc.ko] undefined!
>> ERROR: "fc_remote_port_add" [drivers/scsi/libfc/libfc.ko] undefined!
>> ERROR: "skb_put" [drivers/scsi/libfc/libfc.ko] undefined!
>> ERROR: "skb_clone" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "dev_get_by_name" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "register_netdevice_notifier" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "unregister_netdevice_notifier" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "skb_trim" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "__netdev_alloc_skb" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "__pskb_pull_tail" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "skb_queue_purge" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "__ethtool_get_settings" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "skb_push" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "skb_pull" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "init_net" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "skb_queue_tail" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "kfree_skb" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "skb_dequeue" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "consume_skb" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "dev_queue_xmit" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "skb_put" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>> ERROR: "dev_get_stats" [drivers/scsi/fcoe/libfcoe.ko] undefined!
>>
>> The problem is that there are many different errors seen at various stages
>> during bisect, making a bisect a bit tricky.
>>
>> --------
>> At commit 'xfrm: Generate blackhole routes only from route lookup functions',
>> the error is:
>>
>> drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_event':
>> drivers/scsi/scsi_transport_fc.c:543:7: error: 'scsi_nl_sock' undeclared
>> drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_vendor_event':
>> drivers/scsi/scsi_transport_fc.c:611:7: error: 'scsi_nl_sock' undeclared
>>
>> --------
>> At commit 'bnx2i/bnx2fc : fix randconfig error in next-20140909' and
>> 'scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET',
>> the error is:
>>
>> drivers/built-in.o: In function `scsi_nl_rcv_msg':
>> drivers/scsi/scsi_netlink.c:114: undefined reference to `netlink_ack'
>> drivers/scsi/scsi_netlink.c:116: undefined reference to `skb_pull'
>> drivers/scsi/scsi_netlink.c:80: undefined reference to `netlink_capable'
>> drivers/built-in.o: In function `netlink_kernel_create':
>> include/linux/netlink.h:60: undefined reference to `init_net'
>> include/linux/netlink.h:60: undefined reference to `init_net'
>> include/linux/netlink.h:60: undefined reference to `__netlink_kernel_create'
>> drivers/built-in.o: In function `scsi_netlink_exit':
>> drivers/scsi/scsi_netlink.c:153: undefined reference to `netlink_kernel_release'
>>
>> -------
>>
>> Bisect reports commit 5d6be6a5d486 ('scsi_netlink : Make SCSI_NETLINK dependent
>> on NET instead of selecting NET') as first bad commit.
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
