On 09/10/2014 09:39 AM, Ricardo Ribalda Delgado wrote: > Hello Greg > > Sorry, Probably my bad :). I did resend a new patch using the _IO* > macros, that has been now merged to tty-next > > Regards! > > On Wed, Sep 10, 2014 at 10:25 AM, Markos Chandras > <Markos.Chandras@xxxxxxxxxx> wrote: >> On 09/09/2014 08:17 PM, Greg KH wrote: >>> On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote: >>>> Commit e676253b19b2d269cccf67fdb1592120a0cd0676 >>>> (serial/8250: Add support for RS485 IOCTLs) added cases for the >>>> TIOC{S,G}RS485 commands but this broke the build for MIPS: >>>> >>>> drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl': >>>> drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared >>>> (first use in this function) >>>> drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared >>>> (first use in this function) >>>> >>>> This patch adds these missing definitions >>>> >>>> Cc: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> >>>> Cc: <linux-next@xxxxxxxxxxxxxxx> >>>> Cc: <linux-kernel@xxxxxxxxxxxxxxx> >>>> Cc: <linux-serial@xxxxxxxxxxxxxxx> >>>> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx> >>>> --- >>>> arch/mips/include/uapi/asm/ioctls.h | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h >>>> index b1e637757fe3..34050cb6b631 100644 >>>> --- a/arch/mips/include/uapi/asm/ioctls.h >>>> +++ b/arch/mips/include/uapi/asm/ioctls.h >>>> @@ -76,6 +76,8 @@ >>>> >>>> #define TIOCSBRK 0x5427 /* BSD compatibility */ >>>> #define TIOCCBRK 0x5428 /* BSD compatibility */ >>>> +#define TIOCGRS485 0x542E >>>> +#define TIOCSRS485 0x542F >>> >>> Any reason you aren't using the _IOR() type macros here? >>> >>> thanks, >>> >>> greg k-h >>> >> Hi Greg, >> >> Not really. I am being consistent with what >> include/uapi/asm-generic/ioctls.h is using, and with the xtensa patch >> that was posted yesterday >> >> https://lkml.org/lkml/2014/9/9/27 >> >> -- >> markos > > > Hi Ricardo, Since you are taking care of the same problem on the other architectures, could you also make a similar patch for MIPS so they can all get merged via the same tree? Because, right now, MIPS is still broken. -- markos -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html