On Wednesday, September 10, 2014 10:04:12 AM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, September 09, 2014 03:54:04 PM Mauro Carvalho Chehab wrote: > > This driver depends on a legacy OMAP DMA API. So, it won't > > compile-test on other archs. > > > > While we might add stubs to the functions, this is not a > > good idea, as the hole API should be replaced. > > This is also not a good idea becaouse it would break the driver > for OMAP1 once somebody enables COMPILE_TEST option while also > having ARCH_OMAP1 enabled (which is perfectly fine and shouldn't > cause the driver breakage). In general COMPILE_TEST option is > completely independent from the arch specific ones and it should > not change behaviour of the existing code. Small clarification: I was of course referring to the original patch for the issue: https://lkml.org/lkml/2014/9/9/498 stubs can be added properly with using #if defined(CONFIG_COMPILE_TEST) && !defined(CONFIG_ARCH_OMAP1) similarly like it is handled for ARCH_QCOM in drivers/gpu/drm/msm/msm_drv.h Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
