> -----Original Message----- > From: Michael Chan [mailto:mchan@xxxxxxxxxxxx] > Sent: Tuesday, September 9, 2014 4:21 PM > To: Anish Bhatt > Cc: Randy Dunlap; eddie.wai@xxxxxxxxxxxx; Jim Davis; Stephen Rothwell; > linux-next; linux-kernel; David S. Miller; netdev; James Bottomley > Subject: RE: randconfig build error with next-20140909, in > drivers/net/ethernet/broadcom/cnic.c > > On Tue, 2014-09-09 at 23:16 +0000, Anish Bhatt wrote: > > > It would be really good if SCSI_NETLINK depended on NET instead of > selected NET. > > > We shouldn't have kconfig symbols that use 'select' on entire > subsystems. > > > > As a test, I was able to fix this by this approach : change > > SCSI_NETLINK to depend on NET instead of selecting NET, and replacing > > 'select NETDEVICES ETHERNET NET_VENDOR_BROADCOM CNIC' to > 'depends on > > CNIC' in bnx2i & bnx2fc. (as CNIC already has a dependency on those). > > This removes the need to check for IPV6 in bnx2i/fc Kconfigs as well. > > > > The side effect is that you won't see BNX2 drivers unless CNIC is > > selected, similar for SCSI_NETLINK as well, not sure if there are any other > implications. > > Right. I think it is more user-friendly for BNX2I and BNX2FC to select CNIC. > CNIC is not useful by itself and it makes more sense to select it automatically > when BNX2I/BNX2FC are enabled. > Ok, it can work leaving 'select CNIC' as is, the key is changing the dependency for SCSI_NETLINK from 'select NET' to 'depends on NET' and is basically what fixes the issue with make. removing 'select NETDEVICES ETHERNET NET_VENDOR_BROADCOM' from the bnx2i/fc modules is just cleanup. bnx2i/bnx2fc need a check on IPV6 if we leave 'select CNIC' as is. I have a patch for this ready, but I don't know too much about SCSI_NETLINK, so maybe some else can chime in if this is a good idea ? -Anish -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
