Hi Don,
On Tue, 26 Aug 2014 09:54:17 -0400 Don Zickus <dzickus@xxxxxxxxxx> wrote:
>
> On Tue, Aug 26, 2014 at 05:18:18PM +1000, Stephen Rothwell wrote:
> > Hi Andrew,
> >
> > After merging the akpm tree, today's linux-next build (sparc64
> > defconfig) failed like this:
> >
> > kernel/built-in.o: In function `proc_dowatchdog':
> > (.text+0x6a620): undefined reference to `watchdog_hardlockup_detector_is_enabled'
> > kernel/built-in.o: In function `proc_dowatchdog':
> > (.text+0x6a6a8): undefined reference to `watchdog_enable_hardlockup_detector'
> > kernel/built-in.o: In function `proc_dowatchdog':
> > (.text+0x6a79c): undefined reference to `watchdog_enable_hardlockup_detector'
> >
> > Caused by commit 72355eed4bd7 ("kernel/watchdog.c: control hard lockup
> > detection default"). This build has CONFIG_HAVE_NMI_WATCHDOG=y,
> > CONFIG_HARDLOCKUP_DETECTOR not set.
>
> :-( I was trying to figure out why touch_nmi_watchdog doesn't break the
> same way until I noticed sparc has its own personal implementation of this
> function (instead of using kernel/watchdog.c's version).
>
> We are going to have to split the include/linux/nmi.h changes out into its
> own #ifdef area. I am not sure my brain is quite ready to untangle the
> sparc implementation of the watchdog stuff and try to make it use the
> generic one yet.
>
> This patch I believe fixes the compile problem for now.
>
> Not sure the proper way to post this or who to send this too.
Send it to Andrew Morton (since he has the original patch) who is cc'd
anyway. I will put this in linux-next today instead of reverting the
other patches if he doesn't get around to doing another mmotm before
then.
> From: Don Zickus <dzickus@xxxxxxxxxx>
> Date: Tue, 26 Aug 2014 09:50:21 -0400
> Subject: [PATCH] watchdog, nmi: Fix compile issues on sparc
>
> Sparc doesn't use HARDLOCKUP_DETECTOR the same way x86 does. As a
> result break out the new functions
>
> watchdog_hardlockup_detector_is_enabled
> watchdog_enable_hardlockup_detector
>
> into their own #if defined area. This resolves the compile issue
> where CONFIG_NMI_WATCHDOG=y and CONFIG_HARDLOCKUP_DETECTOR is not set
> on sparc.
Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Don Zickus <dzickus@xxxxxxxxxx>
> ---
> include/linux/nmi.h | 10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/nmi.h b/include/linux/nmi.h
> index 72aacf4..f82a5bf 100644
> --- a/include/linux/nmi.h
> +++ b/include/linux/nmi.h
> @@ -17,14 +17,18 @@
> #if defined(CONFIG_HAVE_NMI_WATCHDOG) ||
> defined(CONFIG_HARDLOCKUP_DETECTOR) #include <asm/nmi.h>
> extern void touch_nmi_watchdog(void);
> -extern void watchdog_enable_hardlockup_detector(bool val);
> -extern bool watchdog_hardlockup_detector_is_enabled(void);
> #else
> static inline void touch_nmi_watchdog(void)
> {
> touch_softlockup_watchdog();
> }
> -static inline void watchdog_enable_hardlockup_detector(bool)
> +#endif
> +
> +#if defined(CONFIG_HARDLOCKUP_DETECTOR)
> +extern void watchdog_enable_hardlockup_detector(bool val);
> +extern bool watchdog_hardlockup_detector_is_enabled(void);
> +#else
> +static inline void watchdog_enable_hardlockup_detector(bool val)
> {
> }
> static inline bool watchdog_hardlockup_detector_is_enabled(void)
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
Attachment:
signature.asc
Description: PGP signature
