On 07/30/2014 05:27 PM, Stephen Rothwell wrote: > Hi John, > > One obvious thing ... > > On Wed, 30 Jul 2014 17:01:05 -0700 John Stultz <john.stultz@xxxxxxxxxx> wrote: >> >> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c >> index fd0158f..d15f48e 100644 >> --- a/drivers/net/wireless/ath/ath9k/hw.c >> +++ b/drivers/net/wireless/ath/ath9k/hw.c >> @@ -1731,19 +1731,14 @@ fail: >> return -EINVAL; >> } >> >> -u32 ath9k_hw_get_tsf_offset(struct timespec *last, struct timespec *cur) >> +u32 ath9k_hw_get_tsf_offset(ktime_t *last, ktime_t *cur) >> { >> - struct timespec ts; >> s64 usec; >> >> - if (!cur) { >> - getrawmonotonic(&ts); >> - cur = &ts; >> - } >> - >> - usec = cur->tv_sec * 1000000ULL + cur->tv_nsec / 1000; >> - usec -= last->tv_sec * 1000000ULL + last->tv_nsec / 1000; >> + if (!cur) >> + *cur = ktime_get_raw(); > > You are assigning through a NULL pointer here ... Gah. That's embarrassing. Thank you. I'll fix that up. thanks john -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html