On Sun, Jul 27, 2014 at 9:46 PM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > Hi Ulf, > > After merging the mmc-uh tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/mmc/host/dw_mmc.c: In function 'dw_mci_reset': > drivers/mmc/host/dw_mmc.c:2262:3: error: implicit declaration of function 'dw_mci_idmac_reset' [-Werror=implicit-function-declaration] > dw_mci_idmac_reset(host); > ^ Hi, sorry about that. It looks like it fails to build when CONFIG_MMC_DW_IDMAC is not set. I changed that bit of code from using #ifdef to using just C if statement, but I think in this case the function being called doesn't exist when CONFIG_MMC_DW_IDMAC is not set, so that was incorrect and we should go back to using something like: #if IS_ENABLED(CONFIG_MMC_DW_IDMAC) /* It is also recommended that we reset and reprogram idmac */ dw_mci_idmac_reset(host); #endif Ulf, I can respin the patch if you'd like or feel free to fix it yourself too. Thanks. > > Caused by commit 25f7dadbd982 ("mmc: dw_mmc: change to use recommended > reset procedure"). > > I have used the mmc-uh tree from next-20140725 for today. > -- > Cheers, > Stephen Rothwell sfr@xxxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html