Hi Paul On Thu, May 29, 2014 at 3:40 PM, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > Hi Trond, > > I'm seeing this on today's linux-next with m68k allmodconfig: > > ERROR: "__umoddi3" [fs/nfs/nfs_layout_nfsv41_files.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > Making this obviously incorrect change makes it go away: > > > /* calculate remaining bytes in the current stripe */ > - stripe_offset = ((u64)req_offset(req) - segment_offset) % stripe_unit; > + stripe_offset = 0; // ((u64)req_offset(req) - segment_offset) % stripe_unit; > > > The line above comes from: > > commit fa1165eda0eeaee57c292df3af1c98e10223f0f5 > Author: Weston Andros Adamson <dros@xxxxxxxxxxxxxxx> > Date: Thu May 15 11:56:56 2014 -0400 > > pnfs: filelayout: support non page aligned layouts > > Looks like it needs to use the proper 64bit math wrappers. Yes. I already fixed up patch this morning in my linux-next branch, so I'm hoping it will be OK the next time you pull from Stephen's tree. For the record, the correct fix should be to replace the above line with div_u64_rem((u64)req_offset(req) - segment_offset, stripe_unit, &stripe_offset); Thanks Trond -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
