On Tue, Mar 25, 2014 at 1:43 AM, Michael Neuling <mikey@xxxxxxxxxxx> wrote: > next-20140324 currently fails compiling celleb_defconfig with: > > arch/powerpc/include/asm/opal.h:894:42: error: 'struct notifier_block' declared inside parameter list [-Werror] > arch/powerpc/include/asm/opal.h:894:42: error: its scope is only this definition or declaration, which is probably not what you want [-Werror] > arch/powerpc/include/asm/opal.h:896:14: error: 'struct notifier_block' declared inside parameter list [-Werror] > > This is due to a missing include which is added here. This build issue has now been in mainline since a few days. > Signed-off-by: Michael Neuling <mikey@xxxxxxxxxxx> > > diff --git a/arch/powerpc/include/asm/opal.h b/arch/powerpc/include/asm/opal.h > index fe2aa0b..f57fb58 100644 > --- a/arch/powerpc/include/asm/opal.h > +++ b/arch/powerpc/include/asm/opal.h > @@ -177,6 +177,8 @@ extern int opal_enter_rtas(struct rtas_args *args, > > #ifndef __ASSEMBLY__ > > +#include <linux/notifier.h> > + > /* Other enums */ > enum OpalVendorApiTokens { > OPAL_START_VENDOR_API_RANGE = 1000, OPAL_END_VENDOR_API_RANGE = 1999 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html