On Mon, 24 Feb 2014 15:17:32 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > > Hi all, > > After merging the tip tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/irqchip/irq-armada-370-xp.c:415:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] > drivers/irqchip/irq-sun4i.c:39:70: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] > drivers/irqchip/irq-sun4i.c:140:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] > drivers/irqchip/irq-gic.c:283:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] > drivers/irqchip/irq-sirfsoc.c:51:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] > drivers/irqchip/irq-vt8500.c:183:1: warning: 'externally_visible' attribute have effect only on public objects [-Wattributes] > > Probably introduced by commit 128ea04a9885 ("lto: Make asmlinkage __visible"). > > I guess that there may be more places where "asmlinkage" is used with > "static" - I assume that they are all incorrect? > > $ git grep -l 'static.*asmlinkage' > arch/x86/crypto/sha1_ssse3_glue.c > arch/x86/crypto/sha256_ssse3_glue.c > arch/x86/crypto/sha512_ssse3_glue.c > drivers/irqchip/irq-armada-370-xp.c > drivers/irqchip/irq-bcm2835.c > drivers/irqchip/irq-gic.c > drivers/irqchip/irq-mmp.c > drivers/irqchip/irq-moxart.c > drivers/irqchip/irq-orion.c > drivers/irqchip/irq-sirfsoc.c > drivers/irqchip/irq-sun4i.c > drivers/irqchip/irq-vic.c > drivers/irqchip/irq-vt8500.c > drivers/irqchip/irq-zevio.c > drivers/pnp/pnpbios/bioscalls.c > scripts/checkpatch.pl > > (the last two don't matter) Any resolution for this? -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
Attachment:
pgptbKSXfVfbR.pgp
Description: PGP signature