On 01/07/14 06:21, Jean Delvare wrote: > Hi Eduardo, > > I suppose this works, however I believe there is value in allowing for > modular building of as much code as possible. ack, yes, please. > I have an alternative proposal, which lets thermal be built as module, > and hopefully also addresses the issue (I can't test...) The only > drawback is that the same dependency must be added for every other > hwmon driver which optionally uses THERMAL_OF. > > From: Jean Delvare <khali@xxxxxxxxxxxx> > > Based on an earlier attempt by Randy Dunlap. > > Fix SENSORS_LM75 dependencies to eliminate build errors: > > drivers/built-in.o: In function `lm75_remove': > lm75.c:(.text+0x12bd8c): undefined reference to `thermal_zone_of_sensor_unregister' > drivers/built-in.o: In function `lm75_probe': > lm75.c:(.text+0x12c123): undefined reference to `thermal_zone_of_sensor_register' > > Add depends on THERMAL since that is what provides the > register/unregister functions above, but only if THERMAL_OF was > selected as this is an optional feature of the driver. > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx> > Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Cc: Eduardo Valentin <eduardo.valentin@xxxxxx> works for me. Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Thanks. > --- > drivers/hwmon/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-3.13-rc7.orig/drivers/hwmon/Kconfig 2014-01-07 09:01:24.812848091 +0100 > +++ linux-3.13-rc7/drivers/hwmon/Kconfig 2014-01-07 15:19:11.039472329 +0100 > @@ -650,6 +650,7 @@ config SENSORS_LM73 > config SENSORS_LM75 > tristate "National Semiconductor LM75 and compatibles" > depends on I2C > + depends on THERMAL || !THERMAL_OF > help > If you say yes here you get support for one common type of > temperature sensor chip, with models including: > > -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
