On Tue, Jan 07, 2014 at 01:04:01PM +0100, Jean Delvare wrote: > Hi Guenter, Randy, > > On Mon, 06 Jan 2014 18:26:34 -0800, Guenter Roeck wrote: > > On 01/06/2014 05:09 PM, Randy Dunlap wrote: > > > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > > > > > Fix SENSORS_LM75 dependencies to eliminate build errors: > > > > > > drivers/built-in.o: In function `lm75_remove': > > > lm75.c:(.text+0x12bd8c): undefined reference to `thermal_zone_of_sensor_unregister' > > > drivers/built-in.o: In function `lm75_probe': > > > lm75.c:(.text+0x12c123): undefined reference to `thermal_zone_of_sensor_register' > > > > > > Add depends on THERMAL_OF since that is what provides the > > > register/unregister functions above. > > > > > > Add depends on THERMAL since THERMAL is a tristate (while THERMAL_OF > > > is a bool) and SENSORS_LM75 (tristate) needs to be limited to modular > > > builds when THERMAL=m. > > > > > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > > --- > > > drivers/hwmon/Kconfig | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > --- linux-next-20140106.orig/drivers/hwmon/Kconfig > > > +++ linux-next-20140106/drivers/hwmon/Kconfig > > > @@ -650,6 +650,8 @@ config SENSORS_LM73 > > > config SENSORS_LM75 > > > tristate "National Semiconductor LM75 and compatibles" > > > depends on I2C > > > + depends on THERMAL > > > + depends on THERMAL_OF > > > help > > > If you say yes here you get support for one common type of > > > temperature sensor chip, with models including: > > > > > > > > NACK. The driver does not and must not depend on THERMAL. > > Correct. > > > This needs to be addressed > > in the thermal code, for example with dummy declarations if THERMAL=m but > > SENSORS_LM75=y. The functions are already declared as dummies if THERMAL_OF=n. > > This won't fly I'm afraid, the number of hwmon drivers affected will > grow in the future and you certainly don't want to have to change the > generic thermal code every time a new driver is added/converted. > That is not really necessary - see the patch fragment I sent as response to the other patch. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
