On Fri, Dec 20, 2013 at 04:26:11PM +0100, Frank Haverkamp wrote: > As requested by Greg, replacing the hexdump function from dynamic_debug.h > with one defined in printk.h. I hope I picked the right one. No, just use the "%*ph" modifier for printk. So, you can do it all on just one line: scnprintf(prefix, sizeof(prefix), "%s %s: %*ph\n", GENWQE_DEVNAME, pci_name(pci_dev), size, buff); And even then, do you really need this genwqe_hexdump() function at all anymore? What is it used for? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html