Hi Jens, [I merged the block tree *before* the aio-direct tree today ...] After merging the block tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: In file included from include/linux/blkdev.h:18:0, from drivers/block/ps3disk.c:22: drivers/block/ps3disk.c: In function 'ps3disk_scatter_gather': include/linux/bio.h:239:9: error: incompatible types when assigning to type 'struct bio_vec *' from type 'struct bio_vec' ((bvl = bio_iter_iovec((bio), (iter))), 1); \ ^ include/linux/bio.h:243:2: note: in expansion of macro '__bio_for_each_segment' __bio_for_each_segment(bvl, bio, iter, (bio)->bi_iter) ^ include/linux/blkdev.h:748:3: note: in expansion of macro 'bio_for_each_segment' bio_for_each_segment(bvl, _iter.bio, _iter.iter) ^ drivers/block/ps3disk.c:102:2: note: in expansion of macro 'rq_for_each_segment' rq_for_each_segment(bvec, req, iter) { ^ include/linux/bio.h:239:41: warning: left-hand operand of comma expression has no effect [-Wunused-value] ((bvl = bio_iter_iovec((bio), (iter))), 1); \ ^ include/linux/bio.h:243:2: note: in expansion of macro '__bio_for_each_segment' __bio_for_each_segment(bvl, bio, iter, (bio)->bi_iter) ^ include/linux/blkdev.h:748:3: note: in expansion of macro 'bio_for_each_segment' bio_for_each_segment(bvl, _iter.bio, _iter.iter) ^ drivers/block/ps3disk.c:102:2: note: in expansion of macro 'rq_for_each_segment' rq_for_each_segment(bvec, req, iter) { ^ include/linux/bio.h:240:45: error: request for member 'bv_len' in something not a structure or union bio_advance_iter((bio), &(iter), (bvl).bv_len)) ^ include/linux/bio.h:243:2: note: in expansion of macro '__bio_for_each_segment' __bio_for_each_segment(bvl, bio, iter, (bio)->bi_iter) ^ include/linux/blkdev.h:748:3: note: in expansion of macro 'bio_for_each_segment' bio_for_each_segment(bvl, _iter.bio, _iter.iter) ^ drivers/block/ps3disk.c:102:2: note: in expansion of macro 'rq_for_each_segment' rq_for_each_segment(bvec, req, iter) { ^ I am not quite sure which commit caused this (maybe ed2d2f9a8265 ("block: Abstract out bvec iterator")?). I have used the block tree from next-20131031 again for today. -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
Attachment:
pgpLt2KIozic6.pgp
Description: PGP signature