On 10/28/2013 03:33 PM, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_clk_notifier_cb': > drivers/tty/serial/xilinx_uartps.c:436:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function) > case PRE_RATE_CHANGE: > ^ > drivers/tty/serial/xilinx_uartps.c:436:7: note: each undeclared identifier is reported only once for each function it appears in > drivers/tty/serial/xilinx_uartps.c:446:36: error: dereferencing pointer to incomplete type > if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud, > ^ > drivers/tty/serial/xilinx_uartps.c:461:7: error: 'POST_RATE_CHANGE' undeclared (first use in this function) > case POST_RATE_CHANGE: > ^ > drivers/tty/serial/xilinx_uartps.c:470:24: error: dereferencing pointer to incomplete type > port->uartclk = ndata->new_rate; > ^ > drivers/tty/serial/xilinx_uartps.c:475:7: error: 'ABORT_RATE_CHANGE' undeclared (first use in this function) > case ABORT_RATE_CHANGE: > ^ > drivers/tty/serial/xilinx_uartps.c: In function 'xuartps_probe': > drivers/tty/serial/xilinx_uartps.c:1385:2: error: implicit declaration of function 'clk_notifier_register' [-Werror=implicit-function-declaration] > if (clk_notifier_register(xuartps_data->refclk, > ^ > drivers/tty/serial/xilinx_uartps.c:1418:2: error: implicit declaration of function 'clk_notifier_unregister' [-Werror=implicit-function-declaration] > clk_notifier_unregister(xuartps_data->refclk, > ^ > > Caused by commits in the tty tree. > > I have left this broken for today. > Soren: Please correct me if I am wrong. But this should be fixed by: "[PATCH 3/3] tty: xuartps: Fix build error when COMMON_CLK is not set" Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
Attachment:
signature.asc
Description: OpenPGP digital signature