On Mon, Jun 24, 2013 at 11:35:40AM +1000, Stephen Rothwell wrote: > Hi Al, > > After merging the vfs tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > In file included from arch/powerpc/xmon/xmon.c:41:0: > arch/powerpc/include/asm/spu.h:245:43: error: 'struct coredump_params' declared inside parameter list [-Werror] > int (*coredump_extra_notes_write)(struct coredump_params *cprm); > ^ > arch/powerpc/include/asm/spu.h:245:43: error: its scope is only this definition or declaration, which is probably not what you want [-Werror] > > Caused by commit 27e58d7e7e6d ("[needs split] switch to saner coredump > primitives"). Presumably, arch/powerpc/include/asm/spu.h needs to > include linux/binfmts.h or just forward declare "struct coredump_params". Mea culpa - it's missing forward + missing include of linux/coredump.h in spufs/coredump.c. I've fixed that and moved that commit to the end of queue - it *does* need a splitup, so it'll get replaced with several commits anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html