Re: [PATCH] usb: gadget: fotg210-udc: Use module_platform_driver_probe macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,


On Thu, Jun 20, 2013 at 8:16 PM, Felipe Balbi <balbi@xxxxxx> wrote:
>
> Hi,
>
> On Thu, Jun 20, 2013 at 01:53:13PM +0000, Yuan-Hsin Chen wrote:
> > Because fotg210-udc is configured as a non-hotpluggable device,
> > that makes sense to use module_platform_driver_probe() instead of
> > module_platform_driver(). This also fixes the section mismatch issue.
> >
> > Signed-off-by: Yuan-Hsin Chen <yhchen@xxxxxxxxxxxxxxxx>
>
> I would rather see you remove __init annotation from your probe()
> function. The reason being that it will users to bind/unbind the driver
> through sysfs, which is pretty good for testing, at least.

I see and will send a patch later. Thanks.

Yuan-Hsin

>
>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux