Hi Jens, Today's linux-next merge of the block tree got a conflict in drivers/block/drbd/drbd_proc.c between commit 4dfac87dca02 ("procfs: new helper - PDE_DATA(inode)") from the vfs tree and commit 193d01532a73 ("drbd: add module_put() on error path in drbd_proc_open()") from the block tree. I fixed it up (see below) and can carry the fix as necessary (no action is required). -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx diff --cc drivers/block/drbd/drbd_proc.c index 928adb8,30fe0a5..0000000 --- a/drivers/block/drbd/drbd_proc.c +++ b/drivers/block/drbd/drbd_proc.c @@@ -313,8 -313,14 +313,14 @@@ static int drbd_seq_show(struct seq_fil static int drbd_proc_open(struct inode *inode, struct file *file) { - if (try_module_get(THIS_MODULE)) - return single_open(file, drbd_seq_show, PDE_DATA(inode)); + int err; + + if (try_module_get(THIS_MODULE)) { - err = single_open(file, drbd_seq_show, PDE(inode)->data); ++ err = single_open(file, drbd_seq_show, PDE_DATA(inode)); + if (err) + module_put(THIS_MODULE); + return err; + } return -ENODEV; }
Attachment:
pgpZ_CqQ5D4Sr.pgp
Description: PGP signature