On Wed, Mar 06, 2013 at 07:13:36PM -0500, Konrad Rzeszutek Wilk wrote: > On PPC64 we get this: > In file included from drivers/staging/zcache/debug.c:2: > drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count': > drivers/staging/zcache/debug.h:16: error: implicit declaration of function 'BUG_ON' > > This simple patch adds the appropiate header file to finish > the compile. > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> > --- > drivers/staging/zcache/debug.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/zcache/debug.h b/drivers/staging/zcache/debug.h > index eef67db..0d9c6b4 100644 > --- a/drivers/staging/zcache/debug.h > +++ b/drivers/staging/zcache/debug.h > @@ -1,5 +1,6 @@ > #ifdef CONFIG_ZCACHE_DEBUG > > +#include <linux/bug.h> > /* we try to keep these statistics SMP-consistent */ Put the #include files at the top of the file. Also, you didn't really test this on linux-next as you can't select this option at the moment, I think you also want to fix that at the same time, unless you really don't want anyone to ever select this option :) Try it again? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
