Re: [PATCH v2] gpio: devm_gpio_* support should not depend on GPIOLIB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 19, 2013 at 2:33 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Fri, Jan 18, 2013 at 8:57 AM, Shawn Guo <shawn.guo@xxxxxxxxxx> wrote:
>
>> Some architectures (e.g. blackfin) provide gpio API without requiring
>> GPIOLIB support (ARCH_WANT_OPTIONAL_GPIOLIB).  devm_gpio_* functions
>> should also work for these architectures, since they do not really
>> depend on GPIOLIB.
>>
>> Add a new option GPIO_DEVRES (enabled by default) to control the build
>> of devres.c.  It also removes the empty version of devm_gpio_*
>> functions for !GENERIC_GPIO build from linux/gpio.h, and moves the
>> function declarations from asm-generic/gpio.h into linux/gpio.h.
>>
>> Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
>
> OK I removed the old version of the patch and pushed this instead.

Hi,

this patch causes the following errors for xtensa defconfig build:

include/asm-generic/gpio.h:265:2: error: implicit declaration of
function '__gpio_get_value' [-Werror=implicit-function-declaration]
include/asm-generic/gpio.h:271:2: error: implicit declaration of
function '__gpio_set_value' [-Werror=implicit-function-declaration]
include/linux/gpio.h:60:90: error: redefinition of 'gpio_cansleep'
include/linux/gpio.h:62:2: error: implicit declaration of function
'__gpio_cansleep' [-Werror=implicit-function-declaration]
include/linux/gpio.h:67:2: error: implicit declaration of function
'__gpio_to_irq' [-Werror=implicit-function-declaration]
drivers/gpio/devres.c:26:2: error: implicit declaration of function
'gpio_free' [-Werror=implicit-function-declaration]
drivers/gpio/devres.c:60:2: error: implicit declaration of function
'gpio_request' [-Werror=implicit-function-declaration]
drivers/gpio/devres.c:90:2: error: implicit declaration of function
'gpio_request_one' [-Werror=implicit-function-declaration]

-- 
Thanks.
-- Max
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux