EXPORT_SYMBOL(min_low_pfn);

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Today i noticed in linux-next this commit:

commit b0d9c17503444c2df8cb8e93ccfa4877edd71933
Author: Sanjay Lal <sanjayl@xxxxxxxxxxx>
Date:   Wed Nov 21 18:34:14 2012 -0800

    MIPS: Export symbols used by KVM/MIPS module

which causes this kernel build warning on ia64:

WARNING: vmlinux: 'min_low_pfn' exported twice. Previous export was in vmlinux


We just need to delete the arch/ia64 specific export (and grep says
for arch/metag too):

$ git grep min_low_pfn | grep EXPORT
arch/ia64/kernel/ia64_ksyms.c:EXPORT_SYMBOL(min_low_pfn);	/* defined
by bootmem.c, but not exported by generic code */
arch/metag/kernel/metag_ksyms.c:EXPORT_SYMBOL(min_low_pfn);
mm/bootmem.c:EXPORT_SYMBOL(min_low_pfn);


Can you do this in the same branch as the mips change so the bits
will flow to Linus together in the next window?

ia64 change (which gmail will no doubt mangle)

From: "Luck, Tony" <tony.luck@xxxxxxxxx>

min_low_pfn is now exported by generic code

Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>

---

diff --git a/arch/ia64/kernel/ia64_ksyms.c b/arch/ia64/kernel/ia64_ksyms.c
index 5b7791d..ca95c8b 100644
--- a/arch/ia64/kernel/ia64_ksyms.c
+++ b/arch/ia64/kernel/ia64_ksyms.c
@@ -25,7 +25,6 @@ EXPORT_SYMBOL(copy_page);

 #ifdef CONFIG_VIRTUAL_MEM_MAP
 #include <linux/bootmem.h>
-EXPORT_SYMBOL(min_low_pfn);    /* defined by bootmem.c, but not
exported by generic code */
 EXPORT_SYMBOL(max_low_pfn);    /* defined by bootmem.c, but not
exported by generic code */
 #endif
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux