On Mon, Feb 4, 2013 at 6:46 AM, Christian Gmeiner <christian.gmeiner@xxxxxxxxx> wrote: > 2013/2/1 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>: >> On Fri, 1 Feb 2013 16:08:15 +0100 >> Christian Gmeiner <christian.gmeiner@xxxxxxxxx> wrote: >> >>> ping >> >> Bryan is handling LEDs patches (see ./MAINTAINERS). Without a cc he >> presumably missed this in the lkml flood. > > You are right... > > ~/kernel/linux-3.7.6$ ./scripts/get_maintainer.pl -f drivers/leds/leds-ot200.c > Bryan Wu <cooloney@xxxxxxxxx> (maintainer:LED SUBSYSTEM) > Richard Purdie <rpurdie@xxxxxxxxx> (maintainer:LED SUBSYSTEM) > linux-leds@xxxxxxxxxxxxxxx (open list:LED SUBSYSTEM) > linux-kernel@xxxxxxxxxxxxxxx (open list) > > Next time I will add Bryan to CC > >> >>> 2013/1/23 GMEINER.Christian <C.GMEINER@xxxxxxxxxxxxx>: >>> >> -----Urspr__ngliche Nachricht----- >>> >> Von: Christian Gmeiner [mailto:christian.gmeiner@xxxxxxxxx] >>> >> Gesendet: Mittwoch, 23. Januar 2013 09:11 >>> >> An: linux-next@xxxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; >>> >> rpurdie@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; GMEINER.Christian >>> >> Cc: Christian Gmeiner >>> >> Betreff: [PATCH] leds-ot200: Fix error caused by shifted mask >>> >> >>> >> During the development of this driver an in-house register documentation >>> >> was used. The last weeks some integration tests were done and this problem >>> >> was found. It turned out that the released register documentation is wrong. >>> >> >>> >> The fix is very simple: shift all masks by one. >>> >> >> >> The changelog failed to describe the effects of the bug it fixes. This >> is a grave (and all too common) omission; it makes it difficult for >> others to determine whether the patch should be backported into earlier >> kernels. >> >> So, please tell us. And feel free to explain whether you believe the >> fix should be backported. > > Our customers can control LEDs from userspace via Java, C++ or what every. They > have running/working applications where they want to control led_3 but > led_2 get's > used. I got a bug report in our in-house bug tracker so it would be > great if this patch can make it into 3.7.x series. > OK, could you please update the commit message of this patch and resubmit it? It's better to submit to -stable tree as well. Thanks, -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
