Hi Heiko, On Thu, Sep 27, 2012 at 1:51 PM, Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote: > On Sun, Sep 16, 2012 at 09:07:54PM +0200, Geert Uytterhoeven wrote: >> After applying http://www.spinics.net/lists/linux-next/msg21973.html, >> the s390 allmodconfig build in linux-next fails in the linking stage with: >> >> ERROR: "free_irq" [drivers/power/smb347-charger.ko] undefined! >> ERROR: "free_irq" [drivers/power/sbs-battery.ko] undefined! >> ERROR: "enable_irq" [drivers/power/max17042_battery.ko] undefined! >> ERROR: "request_irq" [drivers/power/max17042_battery.ko] undefined! >> ERROR: "free_irq" [drivers/power/max17042_battery.ko] undefined! >> ERROR: "disable_irq" [drivers/power/max17042_battery.ko] undefined! >> ERROR: "request_irq" [drivers/power/lp8727_charger.ko] undefined! >> ERROR: "free_irq" [drivers/power/lp8727_charger.ko] undefined! >> ERROR: "request_irq" [drivers/nfc/pn544_hci.ko] undefined! >> ERROR: "free_irq" [drivers/nfc/pn544_hci.ko] undefined! >> ERROR: "request_irq" [drivers/nfc/pn544.ko] undefined! >> ERROR: "free_irq" [drivers/nfc/pn544.ko] undefined! >> ERROR: "request_irq" [drivers/misc/fsa9480.ko] undefined! >> ERROR: "free_irq" [drivers/misc/fsa9480.ko] undefined! >> ERROR: "request_irq" [drivers/misc/bh1770glc.ko] undefined! >> ERROR: "free_irq" [drivers/misc/bh1770glc.ko] undefined! >> ERROR: "request_irq" [drivers/misc/apds990x.ko] undefined! >> ERROR: "free_irq" [drivers/misc/apds990x.ko] undefined! >> >> What should these drivers depend on? GENERIC_HARDIRQS? > > Probably, but... > >> S390 is the only non-GENERIC_HARDIRQS architecture left, but all >> other former non-GENERIC_HARDIRQS architectures did provide e.g. request_irq() >> and free_irq(). > > All of this started because I2C lost its HAS_IOMEM dependency. Can't > we simply add an !S390 dependency instead and all is well? :) > > Something like below? > > From 24c68e72b6198b8412a8605fac7d9c90796502ac Mon Sep 17 00:00:00 2001 > From: Heiko Carstens <heiko.carstens@xxxxxxxxxx> > Date: Thu, 27 Sep 2012 13:37:14 +0200 > Subject: [PATCH] i2c: Make I2C unavailable on s390 again > > "i2c: Make I2C available on UML" removed the IOMEM dependency from I2C which > resulted in I2C being avaible on s390 and causing allmodconfig and allyesconfig > builds to fail: > > drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write': > drivers/misc/altera-stapl/altera-lpt.c:34:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration] > > Adding a HAS_PORT dependency to that driver reveals that there are lots > of other build errors waiting for discovery because of this change since > s390 does not support generic hardirqs: > > ERROR: "free_irq" [drivers/power/smb347-charger.ko] undefined! > ERROR: "free_irq" [drivers/power/sbs-battery.ko] undefined! > ERROR: "enable_irq" [drivers/power/max17042_battery.ko] undefined! > ERROR: "request_irq" [drivers/power/max17042_battery.ko] undefined! > ERROR: "free_irq" [drivers/power/max17042_battery.ko] undefined! > ERROR: "disable_irq" [drivers/power/max17042_battery.ko] undefined! > ERROR: "request_irq" [drivers/power/lp8727_charger.ko] undefined! > ERROR: "free_irq" [drivers/power/lp8727_charger.ko] undefined! > ERROR: "request_irq" [drivers/nfc/pn544_hci.ko] undefined! > ERROR: "free_irq" [drivers/nfc/pn544_hci.ko] undefined! > ERROR: "request_irq" [drivers/nfc/pn544.ko] undefined! > ERROR: "free_irq" [drivers/nfc/pn544.ko] undefined! > ERROR: "request_irq" [drivers/misc/fsa9480.ko] undefined! > ERROR: "free_irq" [drivers/misc/fsa9480.ko] undefined! > ERROR: "request_irq" [drivers/misc/bh1770glc.ko] undefined! > ERROR: "free_irq" [drivers/misc/bh1770glc.ko] undefined! > ERROR: "request_irq" [drivers/misc/apds990x.ko] undefined! > ERROR: "free_irq" [drivers/misc/apds990x.ko] undefined! > > Since UML seems to need generic I2C support, but lot's of now available > drivers fail to compile on s390, just add a !S390 dependency. > > Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Cc: Peter Huewe <peterhuewe@xxxxxx> > Cc: Jean Delvare <khali@xxxxxxxxxxxx> > Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx> Yeah, s390 is so special that it's the only architecture that can be used in depends on !, so Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > --- > drivers/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig > index 17b35c1..2f8c76b 100644 > --- a/drivers/i2c/Kconfig > +++ b/drivers/i2c/Kconfig > @@ -4,6 +4,7 @@ > > menuconfig I2C > tristate "I2C support" > + depends on !S390 > select RT_MUTEXES > ---help--- > I2C (pronounce: I-squared-C) is a slow serial bus protocol used in > -- > 1.7.11.7 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
