On Thu, Sep 20, 2012 at 05:36:22PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init': > drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of function 'isa_virt_to_bus' [-Werror=implicit-function-declaration] > > Caused by commit 1d3ff76759b7 ("i825xx: znet: fix compiler warnings when > building a 64-bit kernel"). Is there some Kconfig dependency missing (CONFIG_ISA)? If we make it dependent on CONFIG_ISA then the driver cannot be built with 64-bit kernel. Then again is there someone running 64-bit kernel on Zenith Z-note notebook? From the pictures it looks like very ancient "laptop". An alternative is to make it depend on X86 like this: diff --git a/drivers/net/ethernet/i825xx/Kconfig b/drivers/net/ethernet/i825xx/Kconfig index fed5080..959faf7 100644 --- a/drivers/net/ethernet/i825xx/Kconfig +++ b/drivers/net/ethernet/i825xx/Kconfig @@ -150,7 +150,7 @@ config SUN3_82586 config ZNET tristate "Zenith Z-Note support (EXPERIMENTAL)" - depends on EXPERIMENTAL && ISA_DMA_API + depends on EXPERIMENTAL && ISA_DMA_API && X86 ---help--- The Zenith Z-Note notebook computer has a built-in network (Ethernet) card, and this is the Linux driver for it. Note that the -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html