On Tue, Jul 17, 2012 at 03:52:10PM +0100, Lee Jones wrote: > I think it would be okay to take the 3 patches due for the v3.6 > merge window, which target the nmk-i2c driver. If any consolidation > happens in the mean-time/future I will personally do the work to > bring the nmk-i2c into line to use any generic bindings which > result. > No one else is ever going to use these vendor specific bindings, so > I'm sure no issues will arise. It also means that we have a fully > enabled driver which is capable of receiving a new configuration via > minor changes to the dts, which is important for the current (only) > user of this driver for an upcoming project. So, this is pretty much what vendors always say about this stuff... Looking at what's specified in the platform data in the current kernel it seems like there's a mixture of things in there that are board and silicon specific. We've got parameters like the the speed mode and timeout which are reasonably board specific but we've also got things like the FIFO sizes which shouldn't be at all board specific and slsu which really looks like it's something that that the driver ought to be able to figure out for itself.
Attachment:
signature.asc
Description: Digital signature
