On Tuesday 03 July 2012, Thierry Reding wrote: > Show Details > On Tue, Jul 03, 2012 at 08:59:11AM +0000, Arnd Bergmann wrote: > > On Tuesday 03 July 2012, Thierry Reding wrote: > > > I came up with the attached patch. What do you think? It fixes the > > > PowerPC allyesconfig issue for me. > > > > This one looks correct, but I would still do it the other way around, > > putting the depends statements into the locations of the other drivers. > > The main difference is that we can then independently convert the > > remaining drivers, without having merge conflicts in the same line > > every time we remove one of the dependencies. > > The downside of that approach, however, is to make PWM override other > settings. For instance if you have TWL6030_PWM selected and then decide > to also select PWM, then the former will be automatically deselected to > satisfy the dependency. I'm not sure if that's desired. It's true that this may be confusing, but I think it's the right approach for future multiplatform kernels. If we have e.g. a combined omap+ux500+imx kernel, we can only have one implementation of the PWM interfaces, and that should be the new one. It's less clear for the other architectures. Maybe a mixed approach is better there, making CONFIG_PWM depend on !MACH_JZ4740 && !PUV3_NB0916 && !BLACKFIN, but letting the remaining ARM versions of the PWM code depend on !PWM. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
