2012/6/21, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>: > On Wed, 20 Jun 2012 18:10:09 -0700 Randy Dunlap <rdunlap@xxxxxxxxxxxx> > wrote: >> >> Someone changes the return type of __const_hweight8() to >> (unsigned long). That causes printk format warnings when >> hweight8/16() etc. is passed a constant: > > That would be "include/linux/bitops.h: fix warning" from the akpm tree > (adding cc's). This patch is made for fix warning message. but it looks affect other side. Sorry for noise, I will look for other mehod. Once would you plz revert this patch in linux-next and akpm tree ? Thanks. > >> >> drivers/input/joystick/analog.c:412:4: warning: format '%d' expects type >> 'int', but argument 4 has type 'long unsigned int' >> drivers/input/joystick/analog.c:412:4: warning: format '%d' expects type >> 'int', but argument 5 has type 'long unsigned int' >> drivers/input/joystick/analog.c:416:5: warning: format '%d' expects type >> 'int', but argument 5 has type 'long unsigned int' >> >> >> Note that in >> >> #define hweight8(w) (__builtin_constant_p(w) ? __const_hweight8(w) : >> __arch_hweight8(w)) >> >> __arch_hweight*() still returns unsigned int while __const_hweight*() >> returns unsigned long. This can't be good, can it? > > -- > Cheers, > Stephen Rothwell sfr@xxxxxxxxxxxxxxxx > -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
