Hi David, > -----Original Message----- > From: David Miller [mailto:davem@xxxxxxxxxxxxx] > Sent: Wednesday, June 20, 2012 10:07 AM > To: Bhupesh SHARMA > Cc: sfr@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > next@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > federico.vaga@xxxxxxxxx; Giancarlo ASNAGHI; wg@xxxxxxxxxxxxxx; > mkl@xxxxxxxxxxxxxx > Subject: Re: linux-next: build failure after merge of the net-next tree > > From: Bhupesh SHARMA <bhupesh.sharma@xxxxxx> > Date: Wed, 20 Jun 2012 12:27:11 +0800 > > > clk_get/clk_put* variants are usually used by ARM platforms. > > Protecting their calls under macro 'CONFIG_HAVE_CLK' should solve the > problem. > > No, we don't pepper foo.c files with crappy ifdefs. So, whether adding a check in Kconfig for HAVE_CLK be a proper solution ? But that will limit the compilation of this driver for only platforms which are ARM based. One may need to support this driver on x86 like platforms also.. Regards, Bhupesh -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html