[CC'ing Wang YanQing, the author of the patch requiring it] On 03/14/2012 09:29 AM, Alan Cox wrote: >>> >>> int pcibios_enabled; >>> +EXPORT_SYMBOL(pcibios_enabled); >>> >>> /* According to the BIOS specification at: >>> * http://members.datafast.net.au/dft0802/specs/bios21.pdf, we could >> >> I would think this should be EXPORT_SYMBOL_GPL()... this seems like a >> symbol with a very high likelihood to be abused in strange ways. > > We don't need to expose it anyway > > uvesafb could look for any PCI vga class device - which I suspect is > what it *should* be doing ? Would this really change depending on whether the page is NX-protected or not? Your suggestion sounds like it is about detecting whether there is any graphic chip present or not while the patch is about fixing an oops caused by NX-protection of the BIOS. Best regards, Florian Tobias Schandinat -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
