Hi Benoit, On Wed, Dec 21, 2011 at 11:51:27AM +0100, Cousson, Benoit wrote: > Hi Stephen, > > On 12/21/2011 7:33 AM, Stephen Rothwell wrote: > >Hi all, > > > >After merging the final tree, today's linux-next build (powerpc > >allyesconfig) failed like this: > > > >drivers/mfd/twl-core.c: In function 'twl_probe': > >drivers/mfd/twl-core.c:1212:22: error: 'TWL6030_IRQ_BASE' undeclared (first use in this function) > >drivers/mfd/twl-core.c:1212:22: note: each undeclared identifier is reported only once for each function it appears in > >drivers/mfd/twl-core.c:1213:39: error: 'TWL6030_BASE_NR_IRQS' undeclared (first use in this function) > >drivers/mfd/twl-core.c:1215:22: error: 'TWL4030_IRQ_BASE' undeclared (first use in this function) > >drivers/mfd/twl-core.c:1216:39: error: 'TWL4030_BASE_NR_IRQS' undeclared (first use in this function) > >drivers/mfd/twl-core.c:1218:3: error: implicit declaration of function 'irq_domain_add_simple' [-Werror=implicit-function-declaration] > > > >Caused by commit 4eea8b1d717d ("mfd: Add initial DT support for > >twl4030/twl6030"). A missing include? Or a CONFIG problem? > > Both in fact... > > There are some nasty dependencies with that TWL driver and the IRQ > defined in OMAP headers only. I was fooled by the name of these > macros. > I naively thought this could be fixed later as written in the > comment I added. I appears this is not the case :-(. > > >This build does not have CONFIG_IRQ_DOMAIN set. > > Ooops, I was not aware of that domain CONFIG. That one is an easy fix. > > > Samuel, > > Just let me know if you will have time for an updated version before Xmas. I have time to merge an updated version, yes. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html