On Thu, Dec 15, 2011 at 11:10:26AM +0100, Kay Sievers wrote: > On Thu, Dec 15, 2011 at 08:21, Greg KH <greg@xxxxxxxxx> wrote: > > On Thu, Dec 15, 2011 at 05:37:54PM +1100, Stephen Rothwell wrote: > >> After merging the driver-core tree, today's linux-next build (x86_64 > >> allmodconfig) failed like this: > >> > >> drivers/xen/xen-selfballoon.c:305:36: error: expected ')' before '(' token > >> drivers/xen/xen-selfballoon.c:327:42: error: expected ')' before '(' token > >> drivers/xen/xen-selfballoon.c:349:48: error: expected ')' before '(' token > >> > >> etc ... > >> > >> [Along with many warnings like: > >> > >> drivers/xen/xen-selfballoon.c:284:8: warning: 'struct device_attribute' declared inside parameter list [enabled by default] > >> ] > >> > >> Presumably caused by commit drivers/xen/xen-selfballoon.c ("xen-balloon: > >> convert sysdev_class to a regular subsystem"). > > > > Ick, Kay, can you make a fix-up patch? > > > > And here I thought I built xen in my test kernel, crap, sorry about > > that. > > It seems it's a compiler version issue, or similar. I'm unable to > reproduce it here, allmodconfig and the Xen part gets through without > any problems. > > I guess we both have very recent systems again. :) > > I expect adding a device.h include will fix it. I'll send you a patch. Yeah, that fixed it (I was able to duplicate this on my laptop, odd that my build machine didn't show it.) Now pushed out to my tree. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html