On Mon, Nov 21, 2011 at 8:12 AM, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote: > From: Randy Dunlap <rdunlap@xxxxxxxxxxxx> > > Fix build errors by adding kconfig dependency on KEYS: > > lib/digsig.c:106:16: error: dereferencing pointer to incomplete type > lib/digsig.c:107:11: error: dereferencing pointer to incomplete type > lib/digsig.c:184:14: error: dereferencing pointer to incomplete type > lib/digsig.c:223:3: error: 'key_ref_t' undeclared (first use in this function) > lib/digsig.c:223:13: error: expected ';' before 'kref' > lib/digsig.c:224:3: error: 'kref' undeclared (first use in this function) > lib/digsig.c:224:3: error: implicit declaration of function 'keyring_search' > lib/digsig.c:231:3: error: implicit declaration of function 'request_key' > > and after changing lib/Kconfig: > warning: (INTEGRITY_DIGSIG) selects DIGSIG which has unmet direct dependencies (CRYPTO && KEYS) > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx> > Cc: Dmitry Kasatkin <dmitry.kasatkin@xxxxxxxxx> > --- > lib/Kconfig | 4 ++-- > security/integrity/Kconfig | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > --- next-2011-1121.orig/lib/Kconfig > +++ next-2011-1121/lib/Kconfig > @@ -294,10 +294,10 @@ config MPILIB_EXTRA > > config DIGSIG > tristate "In-kernel signature checker" > - depends on CRYPTO > + depends on CRYPTO && KEYS this patch was in /crypto dir before, now it is in /lib... I think CRYPTO is not needed at all at the moment.. > select MPILIB > help > Digital signature verification. Currently only RSA is supported. > - Implementation is done using GnuPG MPI library > + Implementation is done using GnuPG MPI library. > > endmenu > --- next-2011-1121.orig/security/integrity/Kconfig > +++ next-2011-1121/security/integrity/Kconfig > @@ -5,7 +5,7 @@ config INTEGRITY > > config INTEGRITY_DIGSIG > boolean "Digital signature verification using multiple keyrings" > - depends on INTEGRITY > + depends on INTEGRITY && CRYPTO && KEYS Is it really needed, because 2 lines bellow is "select DIGSIG", which will depend on KEYS?? > default n > select DIGSIG > help > Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
