On Thu, Nov 17, 2011 at 3:34 AM, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote: > On 11/15/2011 06:33 PM, Stephen Rothwell wrote: >> Hi all, > > > When CONFIG_BUG is not enabled: > > next-2011-1116/drivers/infiniband/ulp/srpt/ib_srpt.c: In function 'srpt_cm_dreq_recv': > next-2011-1116/drivers/infiniband/ulp/srpt/ib_srpt.c:2761:3: error: implicit declaration of function '__WARN' > > > jbd2 has a similar issue (still unpatched). One of the comments in that thread > was that ext4 probably should use WARN_ON() instead of __WARN(). > > Or (Arnd said): > Hmm, my feeling is that we shouldn't do that either, and that jbd2 should > be changed. If we want a function that does what __WARN() does today, we > should probably make a conscious decision about what we want it to be called > and not have it start with "__". <end Arnd> Thanks for reporting this. The __WARN() statements in ib_srpt are present in code paths that should never be reached. I'll post a patch that addresses the build failure. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
