Hi Paul, After merging the moduleh tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/md/dm-bufio.c:988:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:988:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:988:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:997:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:997:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:997:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1006:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1006:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1006:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1036:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1036:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1036:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1049:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1049:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1049:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1059:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1059:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1059:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1135:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1135:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1135:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1158:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1158:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1158:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1232:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1232:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1232:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1238:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1238:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1238:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1245:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1245:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1245:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1251:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1251:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1251:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1257:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1257:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1257:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1263:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1263:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1263:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1269:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1269:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1269:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1489:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1489:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1489:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1534:1: warning: data definition has no type or storage class [enabled by default] drivers/md/dm-bufio.c:1534:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/md/dm-bufio.c:1534:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/md/dm-bufio.c:1676:63: error: expected ')' before 'ulong' drivers/md/dm-bufio.c:1677:40: error: expected ')' before string constant drivers/md/dm-bufio.c:1679:55: error: expected ')' before 'uint' drivers/md/dm-bufio.c:1680:35: error: expected ')' before string constant drivers/md/dm-bufio.c:1682:67: error: expected ')' before 'ulong' drivers/md/dm-bufio.c:1683:40: error: expected ')' before string constant drivers/md/dm-bufio.c:1685:79: error: expected ')' before 'ulong' drivers/md/dm-bufio.c:1686:46: error: expected ')' before string constant drivers/md/dm-bufio.c:1688:87: error: expected ')' before 'ulong' drivers/md/dm-bufio.c:1689:50: error: expected ')' before string constant drivers/md/dm-bufio.c:1691:73: error: expected ')' before 'ulong' drivers/md/dm-bufio.c:1692:43: error: expected ')' before string constant drivers/md/dm-bufio.c:1694:73: error: expected ')' before 'ulong' drivers/md/dm-bufio.c:1695:43: error: expected ')' before string constant drivers/md/dm-bufio.c:1697:15: error: expected declaration specifiers or '...' before string constant drivers/md/dm-bufio.c:1698:20: error: expected declaration specifiers or '...' before string constant drivers/md/dm-bufio.c:1699:16: error: expected declaration specifiers or '...' before string constant Caused by commit 0b068238c5ef ("The dm-bufio interface allows you to do cached I/O on devices") interacting with the modul.h split up. This file should have included module.h in any case. I have added this merg fix patch (Alasdair, this could be added to the device-mapper tree): From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Date: Tue, 1 Nov 2011 18:30:49 +1100 Subject: [PATCH] device-mapper: dm-bufio.c needs to include module.h since it uses the module facilities. Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> --- drivers/md/dm-bufio.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c index cb24666..3a94ef4 100644 --- a/drivers/md/dm-bufio.c +++ b/drivers/md/dm-bufio.c @@ -14,6 +14,7 @@ #include <linux/vmalloc.h> #include <linux/version.h> #include <linux/shrinker.h> +#include <linux/module.h> #define DM_MSG_PREFIX "bufio" -- 1.7.7 -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx http://www.canb.auug.org.au/~sfr/
Attachment:
pgpWO7nW6PDKk.pgp
Description: PGP signature