On Wed, Oct 12, 2011 at 2:30 AM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > Hi Paul, > > After merging the moduleh tree, today's linux-next build (x86_64 > allmodconfig) produced these warnings: > > drivers/net/wireless/brcm80211/brcmutil/wifi.c:43:1: warning: data definition has no type or storage class [enabled by default] > drivers/net/wireless/brcm80211/brcmutil/wifi.c:43:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] > drivers/net/wireless/brcm80211/brcmutil/wifi.c:43:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/net/wireless/brcm80211/brcmutil/wifi.c:79:1: warning: data definition has no type or storage class [enabled by default] > drivers/net/wireless/brcm80211/brcmutil/wifi.c:79:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] > drivers/net/wireless/brcm80211/brcmutil/wifi.c:79:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/net/wireless/brcm80211/brcmutil/wifi.c:136:1: warning: data definition has no type or storage class [enabled by default] > drivers/net/wireless/brcm80211/brcmutil/wifi.c:136:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] > drivers/net/wireless/brcm80211/brcmutil/wifi.c:136:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:348:1: warning: data definition has no type or storage class [enabled by default] > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:348:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:348:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:363:1: warning: data definition has no type or storage class [enabled by default] > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:363:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:363:1: warning: parameter names (without types) in function declaration [enabled by default] > > Caused by commit 5b435de0d786 ("net: wireless: add brcm80211 drivers") > from the wireless tree interacting with the module.h split up. > > I have added the following patch: Thanks Stephen, added to the post merge queue with the other post-merge wireless export.h additions. Paul. > > From 9ea7a8cb92322497a92d464e6e40cd1da20fbcde Mon Sep 17 00:00:00 2001 > From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Date: Wed, 12 Oct 2011 17:22:53 +1100 > Subject: [PATCH] net: wireless; brcm80211: add export.h > > Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > --- > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 1 + > drivers/net/wireless/brcm80211/brcmutil/wifi.c | 2 ++ > 2 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c > index bff9dcd..76c78fd 100644 > --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c > +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c > @@ -21,6 +21,7 @@ > #include <linux/pci_ids.h> > #include <linux/sched.h> > #include <linux/completion.h> > +#include <linux/export.h> > #include <linux/mmc/sdio.h> > #include <linux/mmc/sdio_func.h> > #include <linux/mmc/card.h> > diff --git a/drivers/net/wireless/brcm80211/brcmutil/wifi.c b/drivers/net/wireless/brcm80211/brcmutil/wifi.c > index 509e25c..5616fa8 100644 > --- a/drivers/net/wireless/brcm80211/brcmutil/wifi.c > +++ b/drivers/net/wireless/brcm80211/brcmutil/wifi.c > @@ -13,6 +13,8 @@ > * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN > * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. > */ > +#include <linux/export.h> > + > #include <brcmu_wifi.h> > > /* > -- > 1.7.6.3 > > -- > Cheers, > Stephen Rothwell sfr@xxxxxxxxxxxxxxxx > http://www.canb.auug.org.au/~sfr/ > -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html