On Fri, Sep 30, 2011 at 11:05:14AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, the next-20110929 build (s390x allmodconfig) > failed like this: > > drivers/s390/char/zcore.c:393: error: 'THIS_MODULE' undeclared here (not in a function) > drivers/s390/char/zcore.c:741: error: expected declaration specifiers or '...' before string constant > drivers/s390/char/zcore.c:741: warning: data definition has no type or storage class > drivers/s390/char/zcore.c:741: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' > drivers/s390/char/zcore.c:741: warning: function declaration isn't a prototype > drivers/s390/char/zcore.c:742: error: expected declaration specifiers or '...' before string constant > drivers/s390/char/zcore.c:742: warning: data definition has no type or storage class > drivers/s390/char/zcore.c:742: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' > drivers/s390/char/zcore.c:742: warning: function declaration isn't a prototype > drivers/s390/char/zcore.c:743: error: expected declaration specifiers or '...' before string constant > drivers/s390/char/zcore.c:743: warning: data definition has no type or storage class > drivers/s390/char/zcore.c:743: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' > drivers/s390/char/zcore.c:743: warning: function declaration isn't a prototype > > Probably revealed by the module.h split up. > > This file needs to include module.h Hmm.. wondering why I haven't seen that during my build tests a couple of days ago. Anyway, thanks for letting us know! I added a patch to our local tree. As soon as Martin pushes it out it should be fixed. Thanks, Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
