Hi Paul, After merging the moduleh tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/mmc/core/debugfs.c:28:35: error: expected ')' before numeric constant Caused by commit b5a62f8be3af ("mmc: add module param to set fault injection attributes") from the mmc tree interacting with the module.h split up. I have applied the patch below for today (something similar could be applied to the mmc tree). From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Date: Wed, 28 Sep 2011 18:09:12 +1000 Subject: [PATCH] mmc: using mopdule_param requires the inclusion of moduleparam.h Otherwise the module.h split up produces this error: drivers/mmc/core/debugfs.c:28:35: error: expected ')' before numeric constant Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> --- drivers/mmc/core/debugfs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c index 0a1e7cf..f9e9ff0 100644 --- a/drivers/mmc/core/debugfs.c +++ b/drivers/mmc/core/debugfs.c @@ -9,6 +9,7 @@ */ #include <linux/debugfs.h> #include <linux/fs.h> +#include <linux/moduleparam.h> #include <linux/export.h> #include <linux/seq_file.h> #include <linux/slab.h> -- 1.7.6.3 -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx http://www.canb.auug.org.au/~sfr/ -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html