On 2011-09-19 at 10:46:21 +0200, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc allyesconfig) > failed like this: > > drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_get_devtree_pdata': > drivers/input/keyboard/gpio_keys.c:500:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type > include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **' > drivers/input/keyboard/gpio_keys.c:504:19: warning: assignment makes integer from pointer without a cast > drivers/input/keyboard/gpio_keys.c:508:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type > include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **' > drivers/input/keyboard/gpio_keys.c:509:20: warning: assignment makes integer from pointer without a cast > drivers/input/keyboard/gpio_keys.c:515:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type > include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **' > drivers/input/keyboard/gpio_keys.c:516:33: warning: assignment makes integer from pointer without a cast > drivers/input/keyboard/gpio_keys.c:502:4: error: label 'out_fail' used but not defined > drivers/input/keyboard/gpio_keys.c: At top level: > drivers/input/keyboard/gpio_keys.c:523:7: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token > drivers/input/keyboard/gpio_keys.c:525:2: error: expected identifier or '(' before 'return' > drivers/input/keyboard/gpio_keys.c:527:9: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token > drivers/input/keyboard/gpio_keys.c:529:2: error: expected identifier or '(' before 'return' > drivers/input/keyboard/gpio_keys.c:530:1: error: expected identifier or '(' before '}' token > drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_get_devtree_pdata': > drivers/input/keyboard/gpio_keys.c:521:2: warning: control reaches end of non-void function > > Caused by commit d6ba97c9806b ("Input: gpio_keys - use > of_property_read_u32()"). Mostly by a brace mismatch. Sorry, my fault. I thought I compile-tested this but obviously didn't. I'll send an updated patch to Dmitry. Tobias -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html